fix(ci/eval-stats): resolve prResult symlink#404967
Merged
Mic92 merged 2 commits intoNixOS:masterfrom May 7, 2025
Merged
Conversation
github-actions
bot
added
6.topic: continuous integration
nix-owners
bot
requested review from
LeSuisse,
Mic92,
azuwis,
infinisil,
mweinelt,
philiptaron,
risicle,
wolfgangwalther and
zowoq
Contributor
|
Backport failed for Please cherry-pick the changes locally and resolve any conflicts. git fetch origin release-24.11
git worktree add -d .worktree/backport-404967-to-release-24.11 origin/release-24.11
cd .worktree/backport-404967-to-release-24.11
git switch --create backport-404967-to-release-24.11
git cherry-pick -x c8276114ac18237c8fcf5a2e416578aab58eb393 4f64ebd02b0cf1623bf4bf13a27a7a2d1b186b2e |
13 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the performance stats report.
The problem that can be observed is that the prResult seems to not contain a
/statssubdirectory. So also this PR should also omit the performance report, because the eval.yaml from master is executed.I tested the solution here
This seems to be caused because prResult is a symlink pointing into the nix-store. Weirdly calling
Path(prResult).resolve()in python inside the derivation doesn't work.in constrast i now used
realpathdirectly which works.I didn't manage to find the exact root-cause why
realpathandresolve()behave differently. Here are some of my guesses:Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.